Re: [PATCH 4/4] bus: ti-sysc: Fix bogus resetdone warning for cpsw
From: Tony Lindgren
Date: Sat Oct 31 2020 - 03:12:15 EST
* Grygorii Strashko <grygorii.strashko@xxxxxx> [201030 18:15]:
> Hi Tony,
>
> On 26/10/2020 12:58, Tony Lindgren wrote:
> > The cpsw SOFT_RESET register is cleard when out of reset so let's
> > add SYSS_QUIRK_RESETDONE_INVERTED flag for cpsw. Otherwise we will
> > get bogus "OCP softreset timed out" warnings on boot.
>
> Not sure if this quirk based approach is right way to move forward here.
>
> The cpsw/cpgmac is "ti,sysc-omap4-simple" which means sysc_omap4_simple, which,
> in turn, has .srst_shift = -ENODEV.
>
> And above should be enough to avoid both sysc_reset() and sysc_wait_softreset() for such modules.
That sounds like a much better fix indeed, I'll take a look.
Thanks,
Tony