Re: [PATCH v5 23/25] auxdisplay: charlcd: Do not print chars at end of line
From: Miguel Ojeda
Date: Sat Oct 31 2020 - 05:18:48 EST
Hi Lars,
A few extra typos in this commit message.
On Thu, Oct 29, 2020 at 10:58 AM <poeschel@xxxxxxxxxxx> wrote:
>
> Skip printing characters at the end of a display line. This fits to the
> behaviour we already had, that the cursor is nailed to last position of
to last -> to the last
> a line.
> This might slightly change behaviour.
> On hd44780 displays with one or two lines the previous implementation
> did still write characters to the buffer of the display even if they are
> currently not visible. The shift_display command could be used so set
so -> to
> the "viewing window" to a new position in the buffer and then you could
> see the characters previously written.
> This described behaviour does not work for hd44780 displays with more
> than two display lines. There simply is not enough buffer.
> So the behaviour was a bit inconsistens across different displays.
inconsistent -> inconsistent
> The new behaviour is to stop writing character at the end of a visible
character -> characters
> line, even if there would be room in the buffer. This allows us to have
> an easy implementation, that should behave equal on all supported
> displays. This is not hd44780 hardware dependents anymore.
dependents -> dependent
Cheers,
Miguel