Re: [PATCH AUTOSEL 5.9 087/147] genirq: Add stub for set_handle_irq() when !GENERIC_IRQ_MULTI_HANDLER

[Sasha Levin]

On Tue, Oct 27, 2020 at 08:51:15AM +0000, Marc Zyngier wrote:
> On 2020-10-26 23:48, Sasha Levin wrote:
> > From: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> >
> > [ Upstream commit ea0c80d1764449acf2f70fdb25aec33800cd0348 ]
> >
> > In order to avoid compilation errors when a driver references 
> > set_handle_irq(),
> > but that the architecture doesn't select GENERIC_IRQ_MULTI_HANDLER,
> > add a stub function that will just WARN_ON_ONCE() if ever used.
> >
> > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> > [maz: commit message]
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20200924071754.4509-2-thunder.leizhen@xxxxxxxxxx
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> > include/linux/irq.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/irq.h b/include/linux/irq.h
> > index 1b7f4dfee35b3..b167baef88c0b 100644
> > --- a/include/linux/irq.h
> > +++ b/include/linux/irq.h
> > @@ -1252,6 +1252,12 @@ int __init set_handle_irq(void
> > (*handle_irq)(struct pt_regs *));
> >  * top-level IRQ handler.
> >  */
> > extern void (*handle_arch_irq)(struct pt_regs *) __ro_after_init;
> > +#else
> > +#define set_handle_irq(handle_irq)		\
> > +	do {					\
> > +		(void)handle_irq;		\
> > +		WARN_ON(1);			\
> > +	} while (0)
> > #endif
> >
> > #endif /* _LINUX_IRQ_H */
>
> What is the reason for this backport? The only user is a driver that
> isn't getting backported (d59f7d159891 and following patches).

I'll drop it, thanks!

--
Thanks,
Sasha