Re: [PATCH] Input: st1232 - add support resolution reading
From: kernel test robot
Date: Mon Nov 02 2020 - 13:06:24 EST
Hi Andrej,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on input/next]
[also build test WARNING on v5.10-rc2 next-20201102]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andrej-Valek/Input-st1232-add-support-resolution-reading/20201030-173555
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: i386-randconfig-m021-20201102 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
smatch warnings:
drivers/input/touchscreen/st1232.c:86 st1232_ts_read_resolution() warn: inconsistent indenting
vim +86 drivers/input/touchscreen/st1232.c
74
75 static int st1232_ts_read_resolution(struct st1232_ts_data *ts, u16 *max_x,
76 u16 *max_y)
77 {
78 u8 *buf;
79 int error;
80
81 /* select resolution register */
82 error = st1232_ts_read_data(ts, REG_XY_RESOLUTION);
83 if (error)
84 return error;
85
> 86 buf = ts->read_buf;
87
88 *max_x = ((buf[0] & 0x0070) << 4) | buf[1];
89 *max_y = ((buf[0] & 0x0007) << 8) | buf[2];
90
91 return 0;
92 }
93
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip