Re: [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU

[Dan Murphy]

Hello

On 11/2/20 1:03 PM, Pavel Machek wrote:
> On Mon 2020-11-02 12:29:59, Dan Murphy wrote:
> > Hello
> >
> > On 11/1/20 3:56 AM, Luka Kovacic wrote:
> > > Hello Pavel,
> > >
> > > On Thu, Oct 29, 2020 at 7:01 PM Pavel Machek <pavel@xxxxxx> wrote:
> > > > Hi!
> > > >
> > > > > +What:                /sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/power_status
> > > > > +Date:                September 2020
> > > > > +Contact:     Luka Kovacic <luka.kovacic@xxxxxxxxxx>
> > > > > +Description: (RO) Power status indicates the host platform power on method.
> > > > > +             Value mapping (bitwise list):
> > > > > +             0x80 - Null
> > > > > +             0x40 - Firmware flag
> > > > > +             0x20 - Power loss detection flag (powered off)
> > > > > +             0x10 - Power loss detection flag (AC mode)
> > > > > +             0x08 - Button power on
> > > > > +             0x04 - WOL power on
> > > > > +             0x02 - RTC alarm power on
> > > > > +             0x01 - AC recover power on
> > > > It would be nice to put this into standard place somewhere. Many
> > > > machines will want to expose this information.
> > > As this is specific to this microcontroller and to how it encodes
> > > these values, I don't see a need to change this.
> > > This isn't used anywhere else.
> > >
> > > > If not, at least spell out WoL, as it is not that common of acronym.
> > > Okay.
> > WoL is a very common acronym especially in the networking space
> WoL is common. WOL is not. Better spell it out.

Agreed. Especially if WOL does not mean Wake On Lan

Dan