Re: [PATCH v2 0/2] Add a seqcount between gup_fast and copy_page_range()

From: Linus Torvalds
Date: Mon Nov 02 2020 - 17:45:15 EST


On Mon, Nov 2, 2020 at 2:19 PM Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> wrote:
>
> Disabling preemption for seqcount_t write-side critical sections was
> never a new requirement. It has always been this way, for the reasons
> explained at Documentation/locking/seqlock.rst, "Introduction" section.

Note that that is only true if you spin on the reading side (either of
the two kinds of spinning: (a) spinning to wait for it to become even,
or (b) repeating if they don't match)

Which this code doesn't do, it just fails.

I'm not sure how to perhaps document that.

Linus