Re: [PATCH v2] powerpc/pci: unmap legacy INTx interrupts when a PHB is removed

From: Oliver O'Halloran
Date: Mon Nov 02 2020 - 23:40:43 EST


On Tue, Nov 3, 2020 at 1:39 AM Cédric Le Goater <clg@xxxxxxxx> wrote:
>
> On 10/14/20 4:55 AM, Alexey Kardashevskiy wrote:
> >
> > How do you remove PHBs exactly? There is no such thing in the powernv platform, I thought someone added this and you are fixing it but no. PHBs on powernv are created at the boot time and there is no way to remove them, you can only try removing all the bridges.
>
> yes. I noticed that later when proposing the fix for the double
> free.
>
> > So what exactly are you doing?
>
> What you just said above, with the commands :
>
> echo 1 > /sys/devices/pci0031\:00/0031\:00\:00.0/remove
> echo 1 > /sys/devices/pci0031\:00/pci_bus/0031\:00/rescan

Right, so that'll remove the root port device (and Bus 01 beneath it),
but the PHB itself is still there. If it was removed the root bus
would also disappear.