Re: [PATCH] misc: rtsx: Fix some bugs and add test mode for rts5261

From: Greg KH
Date: Tue Nov 03 2020 - 01:38:27 EST


On Tue, Nov 03, 2020 at 11:27:15AM +0800, rui_feng@xxxxxxxxxxxxxx wrote:
> From: Rui Feng <rui_feng@xxxxxxxxxxxxxx>
>
> 1.Add force test mode
> 2.Fix OCP function
> 3.Use aspm in way of backdoor
> 4.Fix PAD driving
> 5.Not support MMC default
> 6.Support CD&WP reverse
> 7.Add hardware auto power down when unplug card

When you have to list the different things you are doing in a single
patch, that is a huge sign that you need to break this up into much
smaller patches. Please turn this patch into a patch series, each patch
only doing one logical thing.

thanks,

greg k-h