Re: [PATCH v3 1/4] PM / EM: Add a flag indicating units of power values in Energy Model

[Lukasz Luba]

On 11/2/20 1:43 PM, Quentin Perret wrote:
> On Monday 19 Oct 2020 at 15:05:58 (+0100), Lukasz Luba wrote:
> > diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> > index b67a51c574b9..2c31d79bb922 100644
> > --- a/include/linux/energy_model.h
> > +++ b/include/linux/energy_model.h
> > @@ -29,6 +29,8 @@ struct em_perf_state {
> >    * em_perf_domain - Performance domain
> >    * @table:		List of performance states, in ascending order
> >    * @nr_perf_states:	Number of performance states
> > + * @milliwatts:		Flag indicating the power values are in milli-Watts
> > + *			or some other scale.
> >    * @cpus:		Cpumask covering the CPUs of the domain. It's here
> >    *			for performance reasons to avoid potential cache
> >    *			misses during energy calculations in the scheduler
> > @@ -43,6 +45,7 @@ struct em_perf_state {
> >   struct em_perf_domain {
> >   	struct em_perf_state *table;
> >   	int nr_perf_states;
> > +	bool milliwatts;
> >   	unsigned long cpus[];
> >   };
>
> Make that an int please, sizeof(bool) is impdef.

OK, I will change it.

> With that:
>
> Reviewed-by: Quentin Perret <qperret@xxxxxxxxxx>

Thank you for the review.