Re: [PATCH V3] clk: imx8m: fix bus critical clk registration

[Shawn Guo]

On Tue, Nov 03, 2020 at 01:03:44AM +0000, Peng Fan wrote:
> Shawn,
> 
> > Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
> > 
> > On Sun, Nov 01, 2020 at 07:23:54PM +0800, peng.fan@xxxxxxx wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > noc/axi/ahb are bus clk, not peripheral clk.
> > > Since peripheral clk has a limitation that for peripheral clock slice,
> > > IP clock slices must be stopped to change the clock source.
> > >
> > > However if the bus clk is marked as critical clk peripheral, the
> > > assigned clock parent operation will fail.
> > >
> > > So we added CLK_SET_PARENT_GATE flag to avoid glitch.
> > >
> > > And add imx8m_clk_hw_composite_bus_critical for bus critical clock
> > > usage
> > >
> > > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags")
> > > Reviewed-by: Abel Vesa <abel.vesa@xxxxxxx>
> > > Reported-by: Abel Vesa <abel.vesa@xxxxxxx>
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > 
> > Do you want this be picked up as a fix for 5.10-rc or non-critical stuff for
> > -next?
> 
> Please take this as a fix for 5.10-rc.

Okay, I will leave this to Stephen then.

Shawn