Re: [PATCH v2 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro

[Srinivas Kandagatla]

Thanks Pierre for review,

On 29/10/2020 15:56, Pierre-Louis Bossart wrote:
> > diff --git a/sound/soc/codecs/lpass-va-macro.c 
> > b/sound/soc/codecs/lpass-va-macro.c
> > new file mode 100644
> > index 000000000000..8cb23c32631d
> > --- /dev/null
> > +++ b/sound/soc/codecs/lpass-va-macro.c
> > @@ -0,0 +1,882 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +
>
> Missing copyright information?

I will recheck this on all files and fix it before sending next version!

--srini
> [...]
>
> > +module_platform_driver(va_macro_driver);
> > +MODULE_DESCRIPTION("VA macro driver");
> > +MODULE_LICENSE("GPL v2");
>
> "GPL" ? The v2 adds no information.
>
> https://www.kernel.org/doc/html/latest/process/license-rules.html
>
> “GPL”    Module is licensed under GPL version 2. This does not express 
> any distinction between GPL-2.0-only or GPL-2.0-or-later. The exact 
> license information can only be determined via the license information 
> in the corresponding source files.
>
> “GPL v2”    Same as “GPL”. It exists for historic reasons.