Re: [PATCH v7 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

From: Krzysztof Kozlowski
Date: Tue Nov 03 2020 - 08:12:02 EST


On Tue, 3 Nov 2020 at 13:32, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
>
> Hi Chanwoo,
>
> On 03.11.2020 11:45, Chanwoo Choi wrote:
> > On 10/30/20 9:51 PM, Sylwester Nawrocki wrote:
> >> This patch adds registration of a child platform device for the exynos
> >> interconnect driver. It is assumed that the interconnect provider will
> >> only be needed when #interconnect-cells property is present in the bus
> >> DT node, hence the child device will be created only when such a property
> >> is present.
> >>
> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
>
> >> drivers/devfreq/exynos-bus.c | 17 +++++++++++++++++
>
> > We don't need to add 'select INTERCONNECT_EXYNOS' in Kconfig?
>
> I think by doing so we could run into some dependency issues.
>
> > Do you want to remain it as optional according to user?
> Yes, I would prefer to keep it selectable through defconfig.
> Currently it's only needed by one 32-bit ARM board.

I am fine with it as it is really optional.

You could consider then "imply" but then you would need to check for
dependencies (the same as with select).

Best regards,
Krzysztof