Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

[Marc Kleine-Budde]

On 11/3/20 2:36 PM, Ondrej Ille wrote:
> Hello Marc,
> 
> thank you for review, I appreciate it. We will process all your notes, and get
> rid of uin32_t and bitfields then.
> 
> As Pavel pointed out, there are user space tests using this stuff, so it is
> not just search and replace work. We will extend our IP-XACT generation
> toolchain (what a strong word for bunch of python scripts...), to generate 
> Linux specific headers with GEN_MASK and BIT then.

Fine!
> It will take some time, since we have to modify quite a lot of stuff and
> re-test it then, but we will try to do it fast. Btw, do you agree with
> separation of HW specific part of driver into "_hw" file, or would you
> preffer to get rid of this abstraction layer? If we should get rid of it, we
> will, but it would take even more time to do it.

I haven't looked at the HW abstraction yet, but will do next. Usually Linux is
considered the HW abstraction layer :)

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature