Re: [PATCH 0/4] Add GCC and RPMh clock support for SDX55

[Bjorn Andersson]

On Wed 28 Oct 12:08 CDT 2020, Manivannan Sadhasivam wrote:

> On Wed, Oct 28, 2020 at 01:12:28PM +0530, Manivannan Sadhasivam wrote:
> > Hello,
> > 
> > This series adds Global Clock Controller (GCC) and RPMh clock support
> > for SDX55 SoC from Qualcomm with relevant DT bindings.
> > 
> > This series has been tested on SDX55 MTP board. The dts patches for this
> > SoC/board will be posted later.
> > 
> > Thanks,
> > Mani
> > 
> > Manivannan Sadhasivam (1):
> >   clk: qcom: Add support for SDX55 RPMh clocks
> > 
> > Naveen Yadav (1):
> >   clk: qcom: Add SDX55 GCC support
> 
> Bjorn, I've inherited the gcc driver from downstream and did some modification.
> But I'm not sure if I can take the authorship of this patch hence kept it to the
> downstream author.
> 
> In my point of view, the downstream author wrote the driver so I should keep
> the copyright and even list them as MODULE_AUTHOR. But I don't think I should
> give the patch authorship to them because I haven't received the patch anyhow.
> I usually keep the authorship if I take the patch from a source like LKML and
> repost it. But in this case, I authored the patch using someone's code!
> 
> What is your view on this?
> 

I think the author should be the person whom prepared the patch.

Given that the downstream driver is a series of patches from a single
author it's not unreasonable to squash those and retain the author. But
if your effort to prepare the patch for upstream was non-trivial I would
consider it reasonable for you to claim authorship of the patch.

If this is the case it's definitely preferable to give credit to the
original author(s) by mentioning them in the commit message (e.g. "Based
on downstream implementation by Jane Doe").

And the copyright for the work definitely needs to come along, possibly
with the addition of yours, depending on your modifications.

Thanks,
Bjorn

> Thanks,
> Mani
> 
> > 
> > Vinod Koul (2):
> >   dt-bindings: clock: Add SDX55 GCC clock bindings
> >   dt-bindings: clock: Introduce RPMHCC bindings for SDX55
> > 
> >  .../bindings/clock/qcom,gcc-sdx55.yaml        |   71 +
> >  .../bindings/clock/qcom,rpmhcc.yaml           |    1 +
> >  drivers/clk/qcom/Kconfig                      |    8 +
> >  drivers/clk/qcom/Makefile                     |    1 +
> >  drivers/clk/qcom/clk-rpmh.c                   |   20 +
> >  drivers/clk/qcom/gcc-sdx55.c                  | 1667 +++++++++++++++++
> >  include/dt-bindings/clock/qcom,gcc-sdx55.h    |  112 ++
> >  include/dt-bindings/clock/qcom,rpmh.h         |    1 +
> >  8 files changed, 1881 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml
> >  create mode 100644 drivers/clk/qcom/gcc-sdx55.c
> >  create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx55.h
> > 
> > -- 
> > 2.17.1
> >