Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver

From: kernel test robot
Date: Wed Nov 04 2020 - 01:43:53 EST

Next message:
Previous message:
In reply to:
Messages sorted

Hi Perry,

Thank you for the patch!
[auto build test WARNING [also build test WARNING [cannot apply to next-20201103]
[If your patch is applied And when submitting patch, If you fix the issue, Reported-by: kernel test
smatch warnings:
drivers/platform/x86/dell-wmi.c:414 drivers/platform/x86/dell-laptop.c:2207 drivers/platform/x86/dell-laptop.c:2289 drivers/platform/x86/dell-laptop.c:2291
vim +414 drivers/platform/x86/d
83fc44c32ad8b8b Pali Rohár bff589be59c5092 Andy Lutomirski 2015-11-25 bff589be59c5092 Andy Lutomirski 2015-11-25 0b3f6109f0c9ff9 Matthew Garrett 2009-01-09 00ebbeb39b70072 Andy Lutomirski 2017-08-01 83fc44c32ad8b8b Pali Rohár bff589be59c5092 Andy Lutomirski 2015-11-25 83fc44c32ad8b8b Pali Rohár 0b3f6109f0c9ff9 Matthew Garrett 2009-01-09 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 5ea2559726b7862 Rezwanul Kabir 5ea2559726b7862 Rezwanul Kabir 5ea2559726b7862 Rezwanul Kabir 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 00ebbeb39b70072 Andy Lutomirski 2017-08-01 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 481fe5be821c3d0 Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 0b3f6109f0c9ff9 Matthew Garrett 2009-01-09 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár e075b3c898e4055 Pali Rohár e075b3c898e4055 Pali Rohár 0c026c361be1734 Y Paritcher bff589be59c5092 Andy Lutomirski 2015-11-25 83fc44c32ad8b8b Pali Rohár e075b3c898e4055 Pali Rohár e075b3c898e4055 Pali Rohár 83fc44c32ad8b8b Pali Rohár bff589be59c5092 Andy Lutomirski 2015-11-25 e075b3c898e4055 Pali Rohár 83fc44c32ad8b8b Pali Rohár cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan cee9f60d7ca58d8 perry_yuan e075b3c898e4055 Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 0b3f6109f0c9ff9 Matthew Garrett 2009-01-09 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár 83fc44c32ad8b8b Pali Rohár
---
0-DAY CI Kernel Test Service, Description: application/gzip Chao Yu: "[PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE,GARBAGE_COLLECT}_RANGE" Anup Patel: "[PATCH] RISC-V: Use non-PGD mappings for early DTB access" Matthew Garrett: "Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver" by: [ date ] [ thread ] [ subject ] [ author ] Perhaps something to improve:
on linus/master]
on v5.10-rc2]
to the wrong git tree, kindly drop us a note.
we suggest to use '--base' as documented in
//git-scm.com/docs/git-format-patch">https://git-scm.com/docs/git-format-patch]
href="https://github.com/0day-ci/linux/commits/Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721">https://github.com/0day-ci/linux/commits/Perry-Yuan/platform-x86-dell-privacy-Add-support-for-new-privacy-driver/20201103-205721
href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b7cbaf59f62f8ab8f157698f9e31642bff525bd0
(attached as .config)
9.3.0-15) 9.3.0
kindly add following tag as appropriate
robot <lkp@xxxxxxxxx>
dell_wmi_notify() warn: inconsistent indenting
dell_init() warn: inconsistent indenting
dell_exit() warn: inconsistent indenting
dell_exit() warn: curly braces intended?
ell-wmi.c
2014-11-11 377
378 static void dell_wmi_notify(struct wmi_device *wdev,
379 union acpi_object *obj)
380 {
381 struct dell_wmi_priv *priv = dev_get_drvdata(&wdev->dev);
2014-11-11 382 u16 *buffer_entry, *buffer_end;
383 acpi_size buffer_size;
2014-11-11 384 int len, i;
385
2014-11-11 386 if (obj->type != ACPI_TYPE_BUFFER) {
2014-11-11 387 pr_warn("bad response type %x\n", obj->type);
2009-11-02 388 return;
2009-11-02 389 }
2009-11-02 390
2014-11-11 391 pr_debug("Received WMI event (%*ph)\n",
2014-11-11 392 obj->buffer.length, obj->buffer.pointer);
2014-11-11 393
2014-11-11 394 buffer_entry = (u16 *)obj->buffer.pointer;
2014-11-11 395 buffer_size = obj->buffer.length/2;
2014-11-11 396 buffer_end = buffer_entry + buffer_size;
2014-11-11 397
2016-01-04 398 /*
2016-01-04 399 * BIOS/ACPI on devices with WMI interface version 0 does not clear
2016-01-04 400 * buffer before filling it. So next time when BIOS/ACPI send WMI event
2016-01-04 401 * which is smaller as previous then it contains garbage in buffer from
2016-01-04 402 * previous event.
2016-01-04 403 *
2016-01-04 404 * BIOS/ACPI on devices with WMI interface version 1 clears buffer and
2016-01-04 405 * sometimes send more events in buffer at one call.
2016-01-04 406 *
2016-01-04 407 * So to prevent reading garbage from buffer we will process only first
2016-01-04 408 * one event on devices with WMI interface version 0.
2016-01-04 409 */
410 if (priv->interface_version == 0 && buffer_entry < buffer_end)
2016-01-04 411 if (buffer_end > buffer_entry + buffer_entry[0] + 1)
2016-01-04 412 buffer_end = buffer_entry + buffer_entry[0] + 1;
2016-01-04 413
2014-11-11 @414 while (buffer_entry < buffer_end) {
2014-11-11 415
2014-11-11 416 len = buffer_entry[0];
2014-11-11 417 if (len == 0)
2014-11-11 418 break;
2014-11-11 419
2014-11-11 420 len++;
2014-11-11 421
2014-11-11 422 if (buffer_entry + len > buffer_end) {
2014-11-11 423 pr_warn("Invalid length of WMI event\n");
2014-11-11 424 break;
425 }
2014-11-11 426
2014-11-11 427 pr_debug("Process buffer (%*ph)\n", len*2, buffer_entry);
2014-11-11 428
2014-11-11 429 switch (buffer_entry[1]) {
2016-06-15 430 case 0x0000: /* One key pressed or event occurred */
2016-06-15 431 if (len > 2)
2020-06-10 432 dell_wmi_process_key(wdev, buffer_entry[1],
433 buffer_entry[2]);
2014-11-11 434 break;
2016-06-15 435 case 0x0010: /* Sequence of keys pressed */
2016-06-15 436 case 0x0011: /* Sequence of events occurred */
2014-11-11 437 for (i = 2; i < len; ++i)
438 dell_wmi_process_key(wdev, buffer_entry[1],
2016-06-15 439 buffer_entry[i]);
2014-11-11 440 break;
2020-11-03 441 case 0x0012:
2020-11-03 442 #if IS_ENABLED(CONFIG_DELL_PRIVACY)
2020-11-03 443 if (dell_privacy_valid()) {
2020-11-03 444 dell_privacy_process_event(buffer_entry[1], buffer_entry[3],
2020-11-03 445 buffer_entry[4]);
2020-11-03 446 } else {
2020-11-03 447 if (len > 2)
2020-11-03 448 dell_wmi_process_key(wdev, buffer_entry[1], buffer_entry[2]);
2020-11-03 449 }
2020-11-03 450 #else
2020-11-03 451 /* Extended data is currently ignored */
2020-11-03 452 if (len > 2)
2020-11-03 453 dell_wmi_process_key(wdev, buffer_entry[1], buffer_entry[2]);
2020-11-03 454 #endif
2020-11-03 455 break;
2016-06-15 456 default: /* Unknown event */
2014-11-11 457 pr_info("Unknown WMI event type 0x%x\n",
2014-11-11 458 (int)buffer_entry[1]);
2014-11-11 459 break;
460 }
2014-11-11 461
2014-11-11 462 buffer_entry += len;
2014-11-11 463
2014-11-11 464 }
2014-11-11 465
Intel Corporation
//lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Chao Yu: "[PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE,GARBAGE_COLLECT}_RANGE"
Previous message: Anup Patel: "[PATCH] RISC-V: Use non-PGD mappings for early DTB access"
In reply to: Matthew Garrett: "Re: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]