Re: [PATCH 6/8] clk: renesas: r8a779a0-cpg-mssr: add static to local function

From: Geert Uytterhoeven
Date: Wed Nov 04 2020 - 05:54:09 EST


Hi Krzysztof,

On Tue, Nov 3, 2020 at 5:25 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> The function rcar_r8a779a0_cpg_clk_register() is not used outside of the
> unit so it can be made static to fix compilation warning:
>
> drivers/clk/renesas/r8a779a0-cpg-mssr.c:156:21: warning:
> no previous prototype for ‘rcar_r8a779a0_cpg_clk_register’ [-Wmissing-prototypes]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Thanks for your patch!
A fix for this is already queued in renesas-clk-for-v5.11:
https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=renesas-clk-for-v5.11&id=c3f207f6d23d01c0fa817fcd6118bbbc509abe39

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds