Re: [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables

[Andrew Lunn]

On Wed, Nov 04, 2020 at 09:05:59AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’:
>  drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’:
>  drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’:
>  drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’:
>  drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’:
>  drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’:
>  drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’:
>  drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’:
>  drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’:
>  drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’:
>  drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’:
>  drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’:
>  drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’:
>  drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Woojung Huh <woojung.huh@xxxxxxxxxxxxx>
> Cc: Microchip Linux Driver Support <UNGLinuxDriver@xxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew