Re: [PATCH mips-next 0/2] mips: boot: add support for self-extracting FIT images (vmlinuz.itb)

From: Alexander Lobakin
Date: Wed Nov 04 2020 - 08:39:57 EST


From: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Date: Wed, 04 Nov 2020 11:26:09 +0000

> Hi Alexander,

Hi Paul!

> Le dim. 1 nov. 2020 � 15:11, Alexander Lobakin <alobakin@xxxxx> a
> écrit :
>> Commit c3e2ee657418 ("MIPS: generic: Add support for zboot") added
>> support for self-extracting images to Generic MIPS. However, the
>> intended way to boot Generic MIPS kernels is using FIT Images and
>> UHI boot protocol, but currently there's no way to make
>> self-extracting
>> FIT Image (only legacy uzImages).
>>
>> This set consists of two parts:
>> 1) various cleanups in arch/mips/boot/compressed/Makefile as a
>> prerequisite;
>> 2) a new target named "vmlinuz.itb" for composing self-extracting
>> FIT Images, which allows to have the advantages of both UHI and
>> vmlinuz.
>>
>> The second part involves some scenarios duplication, but I think it
>> can be a subject for another series (for constifying and unifying
>> FIT Images rules across the architectures).
>>
>> Alexander Lobakin (2):
>> mips: boot: clean up self-extracting targets scenarios
>> mips: boot: add support for self-extracting FIT images (vmlinuz.itb)
>
> It doesn't break anything on my end, so:
>
> Acked-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
>
> for the series.

Thanks!

> Why vmlinuz.itb and not vmlinuz.fit or vmlinuz.uhi? Is the .itb suffix
> already a thing?

As far as I know -- yes, ITB stands for Image Tree Blob (reference
to Device Tree Blob) and it's a standartized extension for FIT Images
(you can see that all variants for MIPS have ".itb" at the bottom of
arch/mips/boot/Makefile).

> Cheers,
> -Paul

Al

>> arch/mips/Makefile | 3 +-
>> arch/mips/boot/.gitignore | 1 +
>> arch/mips/boot/compressed/Makefile | 96
>> +++++++++++++++++++++++++-----
>> 3 files changed, 85 insertions(+), 15 deletions(-)
>>
>> --
>> 2.29.2