RE: net: macb: linux-next: null pointer dereference in phylink_major_config()

[Parshuram Raju Thombare]

Hi Russell,

It seems apart from changes in driver, we also need check for NULL pcs_config
below or make pcs_config as mandatory method for registering pcs_ops.

456         if (pl->pcs_ops) {
 457                 err = pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_an_mode,
 458                                               state->interface,
 459                                               state->advertising,
 460                                               !!(pl->link_config.pause &
 461                                                  MLO_PAUSE_AN));
 462                 if (err < 0)
 463                         phylink_err(pl, "pcs_config failed: %pe\n",
 464                                     ERR_PTR(err));
 465                 if (err > 0)
 466                         restart = true;
 467         }

Please suggest.

Regards,
Parshuram Thombare