Re: [PATCH v10 0/3] SELinux support for anonymous inodes and UFFD

[Eric Biggers]

On Wed, Nov 04, 2020 at 12:07:16PM -0800, Eric Biggers wrote:
> On Sun, Oct 11, 2020 at 01:29:33AM -0700, Lokesh Gidra wrote:
> > Daniel Colascione (3):
> >   Add a new LSM-supporting anonymous inode interface
> >   Teach SELinux about anonymous inodes
> >   Use secure anon inodes for userfaultfd
> 
> Patches are supposed to have subsystem prefixes, e.g.
> 
> 	fs, security: add a new LSM-supporting anonymous inode interface
> 	selinux: implement init_security_anon()
> 	userfaultfd: use secure anon inodes
> 
> ... but that points to the fact that the first one is really both fs and
> security subsystem changes.  Patches should be one logical change only.  I
> suggest splitting it up into:
> 
> 	security: add init_security_anon() LSM hook
> 	fs: add anon_inode_getfd_secure()

Correction: it's "inode_init_security_anon()", not "init_security_anon()".

- Eric