Re: [PATCH v3 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant

From: Rob Herring
Date: Wed Nov 04 2020 - 16:39:47 EST


On Thu, Oct 29, 2020 at 02:40:16PM +0100, Marek Szyprowski wrote:
> From: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>
> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM:
> dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PCIe
> variant found in the Exynos5433 SoCs.
>
> The main difference in Exynos5433 variant is lack of the MSI support
> (the MSI interrupt is not even routed to the CPU).
>
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> [mszyprow: reworked the driver to support only Exynos5433 variant,
> simplified code, rebased onto current kernel code, added
> regulator support, converted to the regular platform driver,
> removed MSI related code, rewrote commit message, added help]
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> drivers/pci/controller/dwc/Kconfig | 10 +-
> drivers/pci/controller/dwc/pci-exynos.c | 353 ++++++++++--------------
> drivers/pci/quirks.c | 1 +
> 3 files changed, 147 insertions(+), 217 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>