Re: [PATCH net-next v2 07/19] net: phy: mscc: implement generic .handle_interrupt() callback

From: Vladimir Oltean
Date: Wed Nov 04 2020 - 19:09:00 EST


On Sun, Nov 01, 2020 at 02:51:02PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@xxxxxxx>
>
> In an attempt to actually support shared IRQs in phylib, we now move the
> responsibility of triggering the phylib state machine or just returning
> IRQ_NONE, based on the IRQ status register, to the PHY driver. Having
> 3 different IRQ handling callbacks (.handle_interrupt(),
> .did_interrupt() and .ack_interrupt() ) is confusing so let the PHY
> driver implement directly an IRQ handler like any other device driver.
> Make this driver follow the new convention.
>
> Also, remove the .did_interrupt() callback since it's not anymore used.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
> ---

Tested-by: Vladimir Oltean <olteanv@xxxxxxxxx> # VSC8514