Re: [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model

[Lukasz Luba]

On 11/5/20 10:56 AM, Morten Rasmussen wrote:
> On Thu, Nov 05, 2020 at 10:09:05AM +0000, Lukasz Luba wrote:
> > On 11/5/20 9:18 AM, Morten Rasmussen wrote:
> > > On Tue, Nov 03, 2020 at 09:05:57AM +0000, Lukasz Luba wrote:
> > > > @@ -79,7 +82,8 @@ struct em_data_callback {
> > > >    struct em_perf_domain *em_cpu_get(int cpu);
> > > >    struct em_perf_domain *em_pd_get(struct device *dev);
> > > >    int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states,
> > > > -				struct em_data_callback *cb, cpumask_t *span);
> > > > +				struct em_data_callback *cb, cpumask_t *spani,
> > >
> > > "spani" looks like a typo?
> >
> > Good catch, yes, the vim 'i'.
> >
> > Thank you Morten. I will resend this patch when you don't
> > find other issues in the rest of patches.
>
> The rest of the series looks okay to me.

Thank you for checking the whole series. I have re-sent this patch only.

Lukasz

> Morten