Re: bcachefs-for-review

From: Matthew Wilcox
Date: Thu Nov 05 2020 - 11:01:51 EST


On Tue, Oct 27, 2020 at 04:04:33PM -0400, Kent Overstreet wrote:
> Here's where bcachefs is at and what I'd like to get merged:
>
> https://evilpiepirate.org/git/bcachefs.git/log/?h=bcachefs-for-review

When building for x86-32 (ie make allnoconfig, enable BLOCK, enable BCACHEFS):

../fs/bcachefs/util.h:40: warning: "memcpy" redefined
40 | #define memcpy(dst, src, len) \
../arch/x86/include/asm/string_32.h:182: note: this is the location of the previous definition
182 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n)

In function ‘journal_seq_copy’,
inlined from ‘__bch2_create’ at ../fs/bcachefs/fs.c:291:3:
../arch/x86/include/asm/cmpxchg.h:128:3: error: call to ‘__cmpxchg_wrong_size’ declared with attribute error: Bad argument size for cmpxchg
which comes from:
../fs/bcachefs/fs.c:52:16: note: in expansion of macro ‘cmpxchg’
52 | } while ((v = cmpxchg(&dst->ei_journal_seq, old, journal_seq)) != old);

... and similar problems elsewhere in fs.c.