Re: [PATCH v3 3/3] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC

[Matteo Scordino]

Hi,

On Thu, 2020-11-05 at 16:00 +0100, Maxime Ripard wrote:
> On Thu, Nov 05, 2020 at 02:49:45PM +0000, Matteo Scordino wrote:
> > The Elimo Engineering Initium is an Open Source Hardware Single Board
> > Computer based on the Elimo Impetus SoM.
> > 
> > It is meant as the first development platform for the Impetus, providing
> > convenient access to the peripherals on the Impetus.
> > 
> > It provides:
> > USB-C power input
> > UART-to-USB bridge on the USB-C connector, connected to UART1
> > USB-A connector for USB2.0 (Host, Device, OTG)
> > Audio Line In/Out
> > Pin header to access all signals on the M2 connector of the SoM
> > 
> > Signed-off-by: Matteo Scordino <matteo.scordino@xxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/Makefile                   |  1 +
> >  arch/arm/boot/dts/sun8i-s3-elimo-initium.dts | 34 ++++++++++++++++++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 4f0adfead547..50e438ab8a00 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -1208,6 +1208,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
> >  	sun8i-r16-nintendo-super-nes-classic.dtb \
> >  	sun8i-r16-parrot.dtb \
> >  	sun8i-r40-bananapi-m2-ultra.dtb \
> > +	sun8i-s3-elimo-initium.dtb \
> >  	sun8i-s3-lichee-zero-plus.dtb \
> >  	sun8i-s3-pinecube.dtb \
> >  	sun8i-t3-cqa3t-bv3.dtb \
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > new file mode 100644
> > index 000000000000..2119403fb65e
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino <matteo@xxxxxxxx>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-s3-elimo-impetus.dtsi"
> > +
> > +/ {
> > +	model = "Elimo Initium";
> > +	compatible = "elimo,initium", "elimo,impetus", "sochip,s3",
> > +		     "allwinner,sun8i-v3";
> > +
> > +	aliases {
> > +		serial0 = &uart0;
> 
> This alias would come from the DTSI

Removing it.
> 
> > +		serial1 = &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> 
> And this node too

Removing this too. Sorry for the many iterations, as you can probably see by now,
this is my first kernel patch submission =)

> Maxime

Attachment: signature.asc
Description: This is a digitally signed message part