Re: [PATCH v1 1/1] ARM: dts: sun8i: h3: Add initial NanoPi R1 support

[Chen-Yu Tsai]

On Fri, Nov 6, 2020 at 10:03 AM Yu-Tung Chang <mtwget@xxxxxxxxx> wrote:
>
> Maxime Ripard <maxime@xxxxxxxxxx> 于2020年11月6日周五 上午1:10写道：
> >
> > On Wed, Nov 04, 2020 at 04:07:48PM +0800, Yu-Tung Chang wrote:
> > > > > +&uart1 {
> > > > > +     pinctrl-names = "default";
> > > > > +     pinctrl-0 = <&uart1_pins>;
> > > >
> > > > This should be already set in the DTSI
> > > >
> > > uart0 as the debugging interface, uart1 as the external uart port,
> > > uart3 as the bluetooth.
> >
> > What I mean is that since it's the only muxing option, the pinctrl
> > properties should already be set in the DTSI, so it's redundant to put
> > them in the DTS.
> >
> I can only see the definition of uart0 in the DTSI,
> because uart1 as the extension interface is exclusive to NanoPi R1.

Maxime, to clarify, UART1 can be used with or without RTS/CTS,
so there is no default muxing in the DTSI.

ChenYu