Re: [PATCH] net/dsa: remove unused macros to tame gcc warning

[Alex Shi]

在 2020/11/6 下午2:36, Joe Perches 写道:
> On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
>> There are some macros unused, they causes much gcc warnings. Let's
>> remove them to tame gcc.
> 
> I believe these to be essentially poor warnings.
> 
> Aren't these warnings generated only when adding  W=2 to the make
> command line?
> 
> Perhaps it's better to move the warning to level 3
> ---
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 95e4cdb94fe9..5c3c220ddb32 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -68,7 +68,6 @@ KBUILD_CFLAGS += $(call cc-option, -Wlogical-op)
>  KBUILD_CFLAGS += -Wmissing-field-initializers
>  KBUILD_CFLAGS += -Wtype-limits
>  KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized)
> -KBUILD_CFLAGS += $(call cc-option, -Wunused-macros)

This changed too much, and impact others. May not good. :)

Thanks
Alex
>  
>  KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN2
>  
> @@ -89,6 +88,7 @@ KBUILD_CFLAGS += -Wredundant-decls
>  KBUILD_CFLAGS += -Wsign-compare
>  KBUILD_CFLAGS += -Wswitch-default
>  KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat)
> +KBUILD_CFLAGS += $(call cc-option, -Wunused-macros)
>  
>  KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN3
>  
>