Re: [PATCH] x86/kvm: remove unused macro HV_CLOCK_SIZE

[Vitaly Kuznetsov]

Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> writes:

> This macro is useless, and could cause gcc warning:
> arch/x86/kernel/kvmclock.c:47:0: warning: macro "HV_CLOCK_SIZE" is not
> used [-Wunused-macros]
> Let's remove it.
>
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> 
> Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> 
> Cc: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> 
> Cc: Wanpeng Li <wanpengli@xxxxxxxxxxx> 
> Cc: Jim Mattson <jmattson@xxxxxxxxxx> 
> Cc: Joerg Roedel <joro@xxxxxxxxxx> 
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> 
> Cc: Ingo Molnar <mingo@xxxxxxxxxx> 
> Cc: Borislav Petkov <bp@xxxxxxxxx> 
> Cc: x86@xxxxxxxxxx 
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> 
> Cc: kvm@xxxxxxxxxxxxxxx 
> Cc: linux-kernel@xxxxxxxxxxxxxxx 
> ---
>  arch/x86/kernel/kvmclock.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index 34b18f6eeb2c..aa593743acf6 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -44,7 +44,6 @@ static int __init parse_no_kvmclock_vsyscall(char *arg)
>  early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);
>  
>  /* Aligned to page sizes to match whats mapped via vsyscalls to userspace */
> -#define HV_CLOCK_SIZE	(sizeof(struct pvclock_vsyscall_time_info) * NR_CPUS)
>  #define HVC_BOOT_ARRAY_SIZE \
>  	(PAGE_SIZE / sizeof(struct pvclock_vsyscall_time_info))

Fixes: 95a3d4454bb1 ("x86/kvmclock: Switch kvmclock data to a PER_CPU variable")

where the last and the only user was removed.

Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

-- 
Vitaly