Re: [PATCH v2 1/2] dt-bindings: usb: mediatek,mtk-xhci: add str-clock-on
From: Macpaul Lin
Date: Fri Nov 06 2020 - 04:58:47 EST
On Fri, 2020-11-06 at 17:46 +0800, Macpaul Lin wrote:
> Option "mediatek,str-clock-on" means to keep clock on during system
> suspend and resume. Some platform will flush register settings if clock has
> been disabled when system is suspended. Set this option to avoid clock off.
>
> Change-Id: Id841f58e9d7fb3656511072b3eb14d0d355e2dd5
Sorry I've found a Change-ID tag here,
I'll send patch v3.
> Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> ---
> Changes for v2:
> - Rename "mediatek,keep-clock-on" to "mediatek,str-clock-on" which implies
> this option related to STR functions.
> - After discussion with Chunfeng, resend dt-bindings descritption based on
> mediatek,mtk-xhci.txt instead of yaml format.
>
> .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> index 42d8814..fc93bcf 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> @@ -37,6 +37,9 @@ Required properties:
>
> Optional properties:
> - wakeup-source : enable USB remote wakeup;
> + - mediatek,str-clock-on: Keep clock on during system suspend and resume.
> + Some platform will flush register settings if clock has been disabled
> + when system is suspended.
> - mediatek,syscon-wakeup : phandle to syscon used to access the register
> of the USB wakeup glue layer between xHCI and SPM; it depends on
> "wakeup-source", and has two arguments:
Thanks
Macpaul Lin