Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations

From: Greg Kroah-Hartman
Date: Fri Nov 06 2020 - 05:50:14 EST


On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote:
> `struct console_font` is a UAPI structure, thus ideally should not be
> used for kernel internal abstraction. Remove some dummy .con_font_set,
> .con_font_default and .con_font_copy `struct consw` callback
> implementations, to make it cleaner.
>
> Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()"
> depends on this patch, so Cc: stable.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Suggested-by: Daniel Vetter <daniel@xxxxxxxx>
> Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>
> ---
> Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@xxxxxxxxxxxxxx/
>
> drivers/usb/misc/sisusbvga/sisusb_con.c | 21 ---------------------
> drivers/video/console/dummycon.c | 20 --------------------
> 2 files changed, 41 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>