Re: [PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap log

From: Paolo Bonzini
Date: Fri Nov 06 2020 - 06:00:51 EST


On 01/10/20 03:22, Peter Xu wrote:
+ /* Dirty ring tracking is exclusive to dirty log tracking */
+ if (kvm->dirty_ring_size)
+ return -EINVAL;
+

ENXIO is slightly more appropriate (especially for debugging, as EINVAL suggests that the arguments were wrong and not some external state).

Paolo