Re: [PATCH v3 4/4] clk: qcom: camcc: Add camera clock controller driver for SC7180

[Geert Uytterhoeven]

On Thu, Nov 5, 2020 at 5:52 AM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> Quoting Taniya Das (2020-10-16 11:43:35)
> > Add support for the camera clock controller found on SC7180 based devices.
> > This would allow camera drivers to probe and control their clocks.
> >
> > Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> > ---
>
> Applied to clk-next with some minor fixups.

On Fri, Nov 6, 2020 at 8:43 AM <noreply@xxxxxxxxxxxxxx> wrote:
> FAILED linux-next/m68k-allmodconfig/m68k-gcc8 Fri Nov 06, 18:35
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/14393224/
>
> Commit:   Add linux-next specific files for 20201106
>           c34f157421f6905e6b4a79a312e9175dce2bc607
> Compiler: m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30
>
> Possible errors
> ---------------
>
> drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function 'pm_clk_runtime_resume'; did you mean 'pm_runtime_resume'? [-Werror=implicit-function-declaration]
> drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of function 'pm_clk_runtime_suspend'; did you mean 'pm_runtime_suspend'? [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:283: drivers/clk/qcom/camcc-sc7180.o] Error 1
> make[3]: *** [scripts/Makefile.build:500: drivers/clk/qcom] Error 2

The pm_clk_runtime_*() functions are only available if CONFIG_PM=y.
No dummies are provided for the CONFIG_PM=n case yet.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds