Re: [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless

[Lee Jones]

On Mon, 02 Nov 2020, Kalle Valo wrote:

> Lee Jones <lee.jones@xxxxxxxxxx> writes:
> 
> >  [Last batch!]
> >
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (41):
> >   wil6210: wmi: Correct misnamed function parameter 'ptr_'
> >   rsi_91x_usb: Fix some basic kernel-doc issues
> >   rtl8192cu: mac: Fix some missing/ill-documented function parameters
> >   rsi_91x_usb_ops: Source file headers are not good candidates for
> >     kernel-doc
> >   rtl8192cu: trx: Demote clear abuse of kernel-doc format
> >   brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
> >   brcmfmac: pcie: Provide description for missing function parameter
> >     'devinfo'
> >   iwlwifi: mvm: rs: Demote non-conformant function documentation headers
> >   wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
> >   ath9k: ar9330_1p1_initvals: Remove unused const variable
> >     'ar9331_common_tx_gain_offset1_1'
> >   ath9k: ar9340_initvals: Remove unused const variable
> >     'ar9340Modes_ub124_tx_gain_table_1p0'
> >   ath9k: ar9485_initvals: Remove unused const variable
> >     'ar9485_fast_clock_1_1_baseband_postamble'
> >   ath9k: ar9003_2p2_initvals: Remove unused const variables
> >   prism54: isl_ioctl: Fix one function header and demote another
> >   iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
> >   iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's
> >     header
> >   intersil: hostap_hw: Prevent incompatible function type cast
> >   brcm80211: fweh: Add missing description for 'gfp'
> >   ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg'
> >     param
> >   ath9k: ar5008_phy: Demote half completed function headers
> >   ath: dfs_pattern_detector: Fix some function kernel-doc headers
> >   ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
> >   iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
> >   wl3501_cs: Fix misspelling and provide missing documentation
> >   rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
> >   rtlwifi: phy: Remove set but unused variable 'bbvalue'
> >   rtlwifi: halbtc8821a1ant: Remove set but unused variable
> >     'wifi_rssi_state'
> >   rtl8723be: phy: Remove set but unused variable 'lc_cal'
> >   rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
> >   rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
> >   mwifiex: pcie: Remove a couple of unchecked 'ret's
> >   rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
> >   rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
> >   rtl8821ae: phy: Place braces around empty if() body
> >   wlcore: spi: Demote a non-compliant function header, fix another
> >   rtw8822b: Return type is not const
> >   iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
> >   realtek: rtw8822c: Remove unused variable 'corr_val'
> >   ath9k: dynack: Demote non-compliant function header
> >   iwlwifi: fw: acpi: Demote non-conformant function headers
> >   realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
> 
> The cover letter was not CCed to linux-wireless, adding that. But the
> patches itself look ok, I see all 41 of them in pathwork:
> 
> https://patchwork.kernel.org/project/linux-wireless/list/?series=375401&order=date

What's the plan for these Kalle?

Are you able to take the ones that do not require a respin?  It would
certainly safe a great deal of mailing list churn if I only
re-submitted the ones that required refactoring.

Of course if you require me to re-submit all of them, then I will do so.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog