Re: [PATCH v2 0/4] perf drivers: Add sysfs identifier file

[John Garry]

On 08/10/2020 10:26, John Garry wrote:

Hi Will, Mark,

Can you have a look at this series please?

You were cc'ed on the v5 rebase of the userspace part which I sent out a 
little while ago.

Cheers,
John

> To allow perf tool to identify a specific implementation of a PMU for
> event alias matching and metric support, expose a per-PMU identifier file.
>
> There is no standard format for the identifier string. It just should be
> unique per HW implementation.
>
> Typical methods to retrieve the information for the identifier string
> can include:
> - Hardcoding in the driver, matched via DT bindings compat string,
>    ACPI HID, or similar
> - Directly from DT bindings property
> - Read from some HW identification register
>
> In this series, for the SMMUv3 PMU and HiSi uncore drivers, a HW ID
> register is read for the identifier. For the imx8 ddr driver, the
> identifier is hardcoded, matched via DT compat string.
>
> Joakim Zhang (2):
>    bindings/perf/imx-ddr: update compatible string
>    perf/imx_ddr: Add system PMU identifier for userspace
>
> John Garry (2):
>    drivers/perf: hisi: Add identifier sysfs file
>    perf/smmuv3: Support sysfs identifier file
>
>   .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  3 ++
>   drivers/perf/arm_smmuv3_pmu.c                 | 39 ++++++++++++++++
>   drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
>   drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 16 +++++++
>   drivers/perf/hisilicon/hisi_uncore_hha_pmu.c  | 16 +++++++
>   drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c  | 16 +++++++
>   drivers/perf/hisilicon/hisi_uncore_pmu.c      | 10 +++++
>   drivers/perf/hisilicon/hisi_uncore_pmu.h      |  7 +++
>   8 files changed, 149 insertions(+), 3 deletions(-)