Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Make pp3300_a the default supply for pp3300_hub

[Doug Anderson]

Hi,

On Fri, Nov 6, 2020 at 2:01 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> The trogdor design has two options for supplying the 'pp3300_hub' power
> rail, it can be supplied by 'pp3300_l7c' or 'pp3300_a'. The 'pp3300_a'
> path includes a load switch that can be controlled through GPIO84.
> Initially trogdor boards used 'pp3300_l7c' to power the USB hub, newer
> revisions (will) use 'pp3300_a' as supply for 'pp3300_hub'.
>
> Add a DT node for the 'pp3300_a' path and a pinctrl entry for the GPIO.
> Make this path the default and keep trogdor rev1, lazor rev0 and rev1
> on 'pp3300_l7c'. These earlier revisions also allocated the GPIO to the
> purpose of controlling the power switch, so there is no need to limit
> the pinctrl config to newer revisions. Remove the platform-wide
> 'always/boot-on' properties from 'pp3300_l7c' and add them to the
> boards that use this supply. Also delete the 'always/boot-on'
> properties of 'pp3300_hub' for these boards.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - removed 'always-on' and 'boot-on' from 'pp3300_l7c'
> - always pair 'always-on' and 'boot-on' properties
> - removed comment for 'pp3300_hub' 'always-on' and 'boot-on' properties
>
> Changes in v2:
> - added 'always-on' and 'boot-on' properties for new 'pp3300_hub'
> - removed platform-wide 'always-on' property for 'pp3300_l7c'
> - added 'always-on' property to 'pp3300_l7c'  for boards that still
>   use 'pp3300_l7c'
> - delete 'always-on' property of 'pp3300_hub' for boards that still
>   use 'pp3300_l7c'
> - got rid of 'pp3300_hub_7c' label, just use 'pp3300_l7c'
> - fixed position of 'en_pp3300_hub' node to respect ordering
> - updated commit message
>
>  .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 15 ++++++++
>  .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 15 ++++++++
>  .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 15 ++++++++
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi  | 34 +++++++++++++++++--
>  4 files changed, 76 insertions(+), 3 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>