Re: [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver
From: Manivannan Sadhasivam
Date: Mon Nov 09 2020 - 08:31:08 EST
On Fri, Nov 06, 2020 at 09:44:44AM -0800, Bhaumik Bhatt wrote:
> This patch series serves to clean up the MHI host driver by removing an
> unnecessary counter and an unused function. It also renames a function to make
> it clearly worded. There is currently no user of this exported function which
> makes it is safe to do so now.
>
> Bug fixes include adding a missing EXPORT_SYMBOL_GPL to a function, and adding
> a return value check to bail out of RDDM download in kernel panic path.
>
> An outlier among the group exports the mhi_get_exec_env() API for use by
> controller drivers, in case they need to determine behavior on the basis of the
> current execution environment.
>
> This set of patches was tested on arm64.
Series applied to mhi-next!
Thanks,
Mani
>
> v2:
> -Removed the declaration for mhi_get_exec_env() from internal.h
> -Improved on the error log message in RDDM download exit case due to unknown EE
>
> Bhaumik Bhatt (6):
> bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
> bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state()
> bus: mhi: core: Expose mhi_get_exec_env() API for controllers
> bus: mhi: core: Remove unused mhi_fw_load_worker() declaration
> bus: mhi: core: Rename RDDM download function to use proper words
> bus: mhi: core: Skip RDDM download for unknown execution environment
>
> drivers/bus/mhi/core/boot.c | 15 +++++++++------
> drivers/bus/mhi/core/internal.h | 2 --
> drivers/bus/mhi/core/main.c | 2 ++
> include/linux/mhi.h | 12 +++++++++---
> 4 files changed, 20 insertions(+), 11 deletions(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>