Re: [PATCH v4 0/7] arm64: dts: rockchip: Add Engicam PX30.Core

[Jagan Teki]

On Mon, Nov 9, 2020 at 4:45 AM Heiko Stuebner <heiko@xxxxxxxxx> wrote:
>
> Hi,
>
> Am Dienstag, 29. September 2020, 10:32:10 CET schrieb Jagan Teki:
> > PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam.
> >
> > PX30.Core needs to mount on top of Engicam baseboards for creating
> > complete platform boards.
> >
> > Possible baseboards are,
> > - EDIMM2.2 Starter Kit
> > - C.TOUCH 2.0 Carrier Board
> >
> > Changes for v4:
> > - collect Rob A-b
> > Changes for v3:
> > - resolved Johan comments about sorting node properties
> > - add copyright to Amarula Solutions
> > - update px30 dtsi author
> > Changes for v2:
> > - include C.TOUCH 2.0 carrier board
> > - skip 10" OF LCD as it requires separate dts with panel support.
> >
> > Note: These baseboards can be used for i.MX8 SOM's as well. So having
> > baseboard on respective SoC seems to be easy rather than making it
> > common across all.
> >
> > Any inputs?
> > Jagan.
> >
> > Jagan Teki (6):
> >   dt-bindings: arm: rockchip: Add Engicam PX30.Core EDIMM2.2 Starter Kit
> >   arm64: dts: rockchip: px30: Add Engicam EDIMM2.2 Starter Kit
> >   arm64: dts: rockchip: Add Engicam PX30.Core EDIMM2.2 Starter Kit
> >   dt-bindings: arm: rockchip: Add Engicam PX30.Core C.TOUCH 2.0
> >   arm64: dts: rockchip: px30: Add Engicam C.TOUCH 2.0
> >   arm64: dts: rockchip: Add Engicam PX30.Core C.TOUCH 2.0
> >
> > Michael Trimarchi (1):
> >   arm64: dts: rockchip: Add Engicam PX30.Core SOM
>
> I've applied the patches for 5.11 with some changes:
> (1) engicam,px30-px30-core became engicam,px30-core
> (2) px30-px30-core.dtsi became px30-engicam-px30-core.dtsi
>
> That double px30 is unnecessary and confusing in compatibles
> and the px30-core thingy needed something less generic, as that is
> not px30-specific but specific to the engicam boards.

Agreed with the updates and thanks for picking up.

Other than these few patches around the mailing list,  let me know
your comments, thanks!

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20200731160324.142097-1-jagan@xxxxxxxxxxxxxxxxxxxx/
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201023181814.220974-1-jagan@xxxxxxxxxxxxxxxxxxxx/

Jagan.