Re: [PATCH v1] dt-bindings: arm: stm32: lxa,stm32mp157c-mc1: add extra SiP compatible

[Ahmad Fatoum]

Hello Rob,

On 11/9/20 5:37 PM, Rob Herring wrote:
> On Wed, Nov 04, 2020 at 12:39:31PM +0100, Ahmad Fatoum wrote:
>> I know that bindings and device tree patches should be separate. Does
>> this apply here as well? Should I split the dts change into a follow-up
>> commit? 
> 
> Yes.
> 
>> Is it ok that dtbs_check will report an intermittent breakage?
> 
> If the binding comes first, it won't break.
> 
> But generally, 'dtbs_check' being warning free is not yet a requirement. 
> That will probably first have to be per platform.

here the old binding is deleted, so between the patches, there will be
a dtbs_check warning, which is why I asked. I've now split it up with
binding first.

>> +          - const: oct,stm32mp15xx-osd32
> 
> 'oct' is not docuemnted in vendor-prefixes.yaml.

Huh, I only checked whether it's in use, not if it's documented.
I just sent out a v2 with your points addressed.

Thanks for review,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |