Re: [PATCH] mtd: spi-nor: Fix multiple typos
From: Vignesh Raghavendra
Date: Tue Nov 10 2020 - 08:14:33 EST
Hi,
On 11/7/20 7:11 PM, Jonathan Neuschäfer wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
Thanks for the patch, but a commit msg is expected however trivial the
patch maybe. scripts/checkpatch.pl --strict complains about the same:
WARNING: Missing commit description - Add an appropriate one
Regards
Vignesh
> ---
> drivers/mtd/spi-nor/core.c | 4 ++--
> drivers/mtd/spi-nor/sfdp.c | 2 +-
> include/linux/mtd/spi-nor.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 0369d98b2d12e..85c0704945259 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -1447,7 +1447,7 @@ static int spi_nor_erase_multi_sectors(struct spi_nor *nor, u64 addr, u32 len)
>
> /*
> * Erase an address range on the nor chip. The address range may extend
> - * one or more erase sectors. Return an error is there is a problem erasing.
> + * one or more erase sectors. Return an error if there is a problem erasing.
> */
> static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
> {
> @@ -2537,7 +2537,7 @@ spi_nor_select_uniform_erase(struct spi_nor_erase_map *map,
> }
>
> /*
> - * Otherwise, the current erase size is still a valid canditate.
> + * Otherwise, the current erase size is still a valid candidate.
> * Select the biggest valid candidate.
> */
> if (!erase && tested_erase->size)
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index e2a43d39eb5f4..05b22c6576832 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -59,7 +59,7 @@ struct sfdp_bfpt_read {
>
> struct sfdp_bfpt_erase {
> /*
> - * The half-word at offset <shift> in DWORD <dwoard> encodes the
> + * The half-word at offset <shift> in DWORD <dword> encodes the
> * op code and erase sector size to be used by Sector Erase commands.
> */
> u32 dword;
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 60bac2c0ec456..582ee04eeea20 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -406,7 +406,7 @@ static inline struct device_node *spi_nor_get_flash_node(struct spi_nor *nor)
> * @name: the chip type name
> * @hwcaps: the hardware capabilities supported by the controller driver
> *
> - * The drivers can use this fuction to scan the SPI NOR.
> + * The drivers can use this function to scan the SPI NOR.
> * In the scanning, it will try to get all the necessary information to
> * fill the mtd_info{} and the spi_nor{}.
> *
> --
> 2.28.0
>