Re: [PATCH] arm64: tegra186: Add missing CPU PMUs

[Marc Zyngier]

On 2020-11-10 18:22, Thierry Reding wrote:
> On Tue, Nov 10, 2020 at 06:08:31PM +0000, Marc Zyngier wrote:
> > On 2020-11-10 17:36, Thierry Reding wrote:
> > > On Tue, Oct 13, 2020 at 10:58:51AM +0100, Marc Zyngier wrote:
> > > > Add the description of CPU PMUs for both the Denver and A57 clusters,
> > > > which enables the perf subsystem.
> > > >
> > > > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> >
> > [...]
> >
> > > >
> > > > +	pmu_denver {
> > > > +		compatible = "nvidia,denver-pmu", "arm,armv8-pmuv3";
> > >
> > > checkpatch complains that this isn't documented. Did I miss the DT
> > > bindings patch or do we not have one for this?
> >
> > We don't. But I don't think adding a compatible string for each
> > and every micro-architecture makes much sense unless we have something
> > useful to add to that compatible string. Such as a full description
> > of the implementation specific events.
>
> I'm wondering if this isn't going to upset Rob's json-schema bot and
> make him mad.

Rob going mad? Never! ;-)

If you *really* want it, I'll respin this patch with the Denver 
compatible
added to Documentation/devicetree/bindings/arm/pmu.yaml.

        M.
--
Jazz is not dead. It just smells funny...