Re: [PATCH] pinctrl: qcom: Fix msm9853 Kconfig entry to depend on, not select PINCTRL_MSM

[John Stultz]

On Tue, Nov 10, 2020 at 11:29 AM Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx> wrote:
>
> On 11/10/2020 12:00 PM, John Stultz wrote:
> > One fixup following my patch commit be117ca32261 ("pinctrl:
> > qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then
> > a selected config") being queued in LinusW's tree, as a new
> > config entry was added for the msm9853 that also needs the
> > change.
> >
> > Applies to LinusW's pinctrl devel tree.
> >
> > Cc: Andy Gross <agross@xxxxxxxxxx>
> > Cc: Prasad Sodagudi <psodagud@xxxxxxxxxxxxxx>
> > Cc: Vladimir Lypak <junak.pub@xxxxxxxxx>
> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> > Cc: linux-gpio@xxxxxxxxxxxxxxx
> > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> > ---
> >   drivers/pinctrl/qcom/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> > index 8bdf878fe970c..cf56e029cd9c7 100644
> > --- a/drivers/pinctrl/qcom/Kconfig
> > +++ b/drivers/pinctrl/qcom/Kconfig
> > @@ -115,7 +115,7 @@ config PINCTRL_MSM8916
> >   config PINCTRL_MSM8953
> >       tristate "Qualcomm 8953 pin controller driver"
> >       depends on GPIOLIB && OF
> > -     select PINCTRL_MSM
> > +     depends on PINCTRL_MSM
> >       help
> >         This is the pinctrl, pinmux, pinconf and gpiolib driver for the
> >         Qualcomm TLMM block found on the Qualcomm MSM8953 platform.
> >
>
> Subject should indicate msm8953, no?
>

Sorry, I'm confused. :)
The subject is "pinctrl: qcom: Fix msm9853 Kconfig..." is there
something more specific you are suggesting?

thanks
-john