Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops

From: Greg KH
Date: Tue Nov 10 2020 - 15:40:42 EST


On Tue, Nov 10, 2020 at 12:53:27PM -0700, Shuah Khan wrote:
> +Decrement interface
> +-------------------
> +
> +Decrements sequence number and doesn't return the new value. ::
> +
> + seqnum32_dec() --> atomic_dec()
> + seqnum64_dec() --> atomic64_dec()

Why would you need to decrement a sequence number? Shouldn't they just
always go up?

I see you use them in your patch 12/13, but I don't think that really is
a sequence number there, but rather just some other odd value :)

thanks,

greg k-h