Re: [PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation

[Alex Deucher]

On Tue, Nov 10, 2020 at 2:31 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/radeon/radeon_vm.c:131: warning: Function parameter or member 'rdev' not described in 'radeon_vm_get_bos'
>  drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess function parameter 'start' description in 'radeon_vm_update_page_directory'
>  drivers/gpu/drm/radeon/radeon_vm.c:643: warning: Excess function parameter 'end' description in 'radeon_vm_update_page_directory'
>  drivers/gpu/drm/radeon/radeon_vm.c:819: warning: Function parameter or member 'ib' not described in 'radeon_vm_update_ptes'
>  drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Function parameter or member 'bo_va' not described in 'radeon_vm_bo_update'
>  drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter 'vm' description in 'radeon_vm_bo_update'
>  drivers/gpu/drm/radeon/radeon_vm.c:915: warning: Excess function parameter 'bo' description in 'radeon_vm_bo_update'
>  drivers/gpu/drm/radeon/radeon_vm.c:1155: warning: Excess function parameter 'vm' description in 'radeon_vm_bo_invalidate'
>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Applied with a small fixup.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_vm.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index 27b14eff532cb..71f2edcac6ea0 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -119,6 +119,7 @@ void radeon_vm_manager_fini(struct radeon_device *rdev)
>  /**
>   * radeon_vm_get_bos - add the vm BOs to a validation list
>   *
> + * @rdev: radeon_device pointer
>   * @vm: vm providing the BOs
>   * @head: head of validation list
>   *
> @@ -629,8 +630,6 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)
>   *
>   * @rdev: radeon_device pointer
>   * @vm: requested vm
> - * @start: start of GPU address range
> - * @end: end of GPU address range
>   *
>   * Allocates new page tables if necessary
>   * and updates the page directory (cayman+).
> @@ -802,6 +801,7 @@ static void radeon_vm_frag_ptes(struct radeon_device *rdev,
>   *
>   * @rdev: radeon_device pointer
>   * @vm: requested vm
> + * @ib: indirect buffer to use for the update
>   * @start: start of GPU address range
>   * @end: end of GPU address range
>   * @dst: destination address to map to
> @@ -900,8 +900,7 @@ static void radeon_vm_fence_pts(struct radeon_vm *vm,
>   * radeon_vm_bo_update - map a bo into the vm page table
>   *
>   * @rdev: radeon_device pointer
> - * @vm: requested vm
> - * @bo: radeon buffer object
> + * @bo_va: radeon buffer object
>   * @mem: ttm mem
>   *
>   * Fill in the page table entries for @bo (cayman+).
> @@ -1145,7 +1144,6 @@ void radeon_vm_bo_rmv(struct radeon_device *rdev,
>   * radeon_vm_bo_invalidate - mark the bo as invalid
>   *
>   * @rdev: radeon_device pointer
> - * @vm: requested vm
>   * @bo: radeon buffer object
>   *
>   * Mark @bo as invalid (cayman+).
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel