Re: [PATCH V3] memory: tegra: add missing put_device() call in error path of tegra_emc_probe()

From: yukuai (C)
Date: Tue Nov 10 2020 - 20:11:32 EST


On 2020/11/10 23:21, Krzysztof Kozlowski wrote:
On Tue, Nov 10, 2020 at 09:33:11AM +0800, Yu Kuai wrote:
The reference to device obtained with of_find_device_by_node() should
be dropped. Thus add jump target to fix the exception handling for this
function implementation.

Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver")
Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
---
drivers/memory/tegra/tegra124-emc.c | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)

I think you missed my previous comment about the issue being fixed
already. Are you sure you rebased this on top of latest next?


Hi,

It's true the issue was fixed.

Thanks,
Yu Kuai
Best regards,
Krzysztof
.