Re: [PATCH][next] Bluetooth: btrtl: fix incorrect skb allocation failure check

From: Marcel Holtmann
Date: Wed Nov 11 2020 - 05:54:52 EST


Hi Colin,

> Currently the check for a failed bt_skb_alloc allocation is incorrectly
> checking using IS_ERR and this can lead to a null pointer dereference. Fix
> this by checking for a null pointer return using the !skb idiom.
>
> Addresses-Coverity: ("Dereference null return")
> Fixes: 1996d9cad6ad ("Bluetooth: btrtl: Ask 8821C to drop old firmware")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/bluetooth/btrtl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel