Re: [PATCH v21 05/19] mm/vmscan: remove unnecessary lruvec adding

[Vlastimil Babka]

On 11/5/20 9:55 AM, Alex Shi wrote:
> We don't have to add a freeable page into lru and then remove from it.
> This change saves a couple of actions and makes the moving more clear.
>
> The SetPageLRU needs to be kept before put_page_testzero for list
> integrity, otherwise:
>
>    #0 move_pages_to_lru             #1 release_pages
>    if !put_page_testzero
>       			           if (put_page_testzero())
>       			              !PageLRU //skip lru_lock
>       SetPageLRU()
>       list_add(&page->lru,)
>                                           list_add(&page->lru,)
>
> [akpm@xxxxxxxxxxxxxxxxxxxx: coding style fixes]
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>
> Acked-by: Hugh Dickins <hughd@xxxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> Cc: Hugh Dickins <hughd@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

Nice cleanup!