Re: [PATCH 0/4] ARM: dts: aspeed: Add Facebook Galaxy100 BMC

[Joel Stanley]

On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@xxxxxxxxx> wrote:
>
> From: Tao Ren <rentao.bupt@xxxxxxxxx>
>
> The patch series adds the initial version of device tree for Facebook
> Galaxy100 (AST2400) BMC.
>
> Patch #1 adds common dtsi to minimize duplicated device entries across
> Facebook Network AST2400 BMC device trees.
>
> Patch #2 simplfies Wedge40 device tree by using the common dtsi.
>
> Patch #3 simplfies Wedge100 device tree by using the common dtsi.
>
> Patch #4 adds the initial version of device tree for Facebook Galaxy100
> BMC.

Nice. They look good to me.

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

Is there another person familiar with the design you would like to
review before I merge?


>
> Tao Ren (4):
>   ARM: dts: aspeed: Common dtsi for Facebook AST2400 Network BMCs
>   ARM: dts: aspeed: wedge40: Use common dtsi
>   ARM: dts: aspeed: wedge100: Use common dtsi
>   ARM: dts: aspeed: Add Facebook Galaxy100 (AST2400) BMC
>
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../dts/aspeed-bmc-facebook-galaxy100.dts     |  57 +++++++++
>  .../boot/dts/aspeed-bmc-facebook-wedge100.dts | 120 +++---------------
>  .../boot/dts/aspeed-bmc-facebook-wedge40.dts  | 112 +---------------
>  .../dts/ast2400-facebook-netbmc-common.dtsi   | 117 +++++++++++++++++
>  5 files changed, 191 insertions(+), 216 deletions(-)
>  create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dts
>  create mode 100644 arch/arm/boot/dts/ast2400-facebook-netbmc-common.dtsi
>
> --
> 2.17.1
>