Re: [PATCH] Input: touchscreen: fix kconfig dependency bug for TOUCHSCREEN_ADC
From: Dmitry Torokhov
Date: Thu Nov 12 2020 - 00:43:57 EST
On Tue, Nov 03, 2020 at 01:15:05AM +0300, Necip Fazil Yildiran wrote:
> When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
> Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
> Selected by [y]:
> - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]
>
> The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
> on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
> can also fail building the kernel.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Fixes: aa132ffb6b0a ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=209881
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
Applied, thank you.
--
Dmitry