RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

[Ardelean, Alexandru]

> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Sent: Thursday, November 12, 2020 2:38 AM
> To: Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for error in probe
> 
> [External]
> 
> Hi Alexandru,
> 
> On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote:
> > The 'error' & 'ret' variables are used. This is a bit of duplication.
> > This change replaces the use of error with the 'ret' variable since
> > the name is a bit more generic.
> 
> I really prefer variables that carry error codes/success and are used in error
> paths to be called "error", and "ret" or "retval" to be used in cases where we
> may return actual data.
> 

Ack.
Will do it the other way around for v2.

> Thanks.
> 
> --
> Dmitry