Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()

[Bartosz Golaszewski]

On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
<zhangchangzhong@xxxxxxxxxx> wrote:
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 1325055..2ebacb6 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev)
>                                       mtk_star_adjust_link, 0, priv->phy_intf);
>         if (!priv->phydev) {
>                 netdev_err(ndev, "failed to connect to PHY\n");
> +               ret = -ENODEV;
>                 goto err_free_irq;
>         }
>
> --
> 2.9.5
>

Acked-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>